| To: | Jakub Bogusz <qboosh@xxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH v2] xfsprogs: fix various incorrect printf formats |
| From: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
| Date: | Sat, 5 Nov 2011 05:33:17 -0400 |
| Cc: | xfs@xxxxxxxxxxx, Christoph Hellwig <hch@xxxxxxxxxxxxx> |
| In-reply-to: | <20111105090029.GA15258@xxxxxxxxxxxxxxxxxx> |
| References: | <20111025115233.GB22103@xxxxxxxxxxxxx> <20111025155916.GA19818@xxxxxxxxxxxxxxxxxx> <20111102092012.GA3808@xxxxxxxxxxxxx> <20111105090029.GA15258@xxxxxxxxxxxxxxxxxx> |
| User-agent: | Mutt/1.5.21 (2010-09-15) |
> > do_warn(
> > -_("inode 0x%" PRIu64 "bmap block 0x%" PRIu64 " claimed, state is %d\n"),
> > +_("inode 0x%" PRIu64 "bmap block 0x%" PRIx64 " claimed, state is %d\n"),
> > ino, bno, state);
> > break;
> > case XR_E_MULT:
> > case XR_E_INUSE_FS:
> > set_bmap(agno, agbno, XR_E_MULT);
> > do_warn(
> > -_("inode 0x%" PRIu64 " bmap block 0x%" PRIu64 " claimed, state is %d\n"),
> > +_("inode 0x%" PRIu64 " bmap block 0x%" PRIx64 " claimed, state is %d\n"),
> > ino, bno, state);
> > /*
> > * if we made it to here, this is probably a bmap block
>
> These two entries still need fix in the first format strings of both
> msgids...
>
> I'm attaching my version of the whole patch.
I've already put the previous version in. I'll commit the updates
attributed to you.
Sorry for the mess, and thanks a lot for looking over this.
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | XFS status update for October 2011, Christoph Hellwig |
|---|---|
| Next by Date: | Online TRIM/discard performance impact, Martin Rusko |
| Previous by Thread: | Re: [PATCH v2] xfsprogs: fix various incorrect printf formats, Jakub Bogusz |
| Next by Thread: | world wide gaming even when you lose you win, admin |
| Indexes: | [Date] [Thread] [Top] [All Lists] |