xfs
[Top] [All Lists]

Re: [PATCH v2] xfsprogs: fix various incorrect printf formats

To: xfs@xxxxxxxxxxx
Subject: Re: [PATCH v2] xfsprogs: fix various incorrect printf formats
From: Jakub Bogusz <qboosh@xxxxxxxxxxxxx>
Date: Sat, 5 Nov 2011 10:00:29 +0100
Cc: Christoph Hellwig <hch@xxxxxxxxxxxxx>
In-reply-to: <20111102092012.GA3808@xxxxxxxxxxxxx>
References: <20111025115233.GB22103@xxxxxxxxxxxxx> <20111025155916.GA19818@xxxxxxxxxxxxxxxxxx> <20111102092012.GA3808@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Wed, Nov 02, 2011 at 05:20:12AM -0400, Christoph Hellwig wrote:
> Index: xfsprogs/repair/scan.c
> ===================================================================
> --- xfsprogs.orig/repair/scan.c       2011-10-30 05:56:36.168127218 +0100
> +++ xfsprogs/repair/scan.c    2011-10-30 05:57:45.981169953 +0100
> @@ -289,14 +289,14 @@ _("bad back (left) sibling pointer (saw
>                        */
>                       set_bmap(agno, agbno, XR_E_MULT);
>                       do_warn(
> -_("inode 0x%" PRIu64 "bmap block 0x%" PRIu64 " claimed, state is %d\n"),
> +_("inode 0x%" PRIu64 "bmap block 0x%" PRIx64 " claimed, state is %d\n"),
>                               ino, bno, state);
>                       break;
>               case XR_E_MULT:
>               case XR_E_INUSE_FS:
>                       set_bmap(agno, agbno, XR_E_MULT);
>                       do_warn(
> -_("inode 0x%" PRIu64 " bmap block 0x%" PRIu64 " claimed, state is %d\n"),
> +_("inode 0x%" PRIu64 " bmap block 0x%" PRIx64 " claimed, state is %d\n"),
>                               ino, bno, state);
>                       /*
>                        * if we made it to here, this is probably a bmap block

These two entries still need fix in the first format strings of both
msgids...

I'm attaching my version of the whole patch.


-- 
Jakub Bogusz    http://qboosh.pl/

Attachment: xfsprogs-msgids.patch
Description: Text document

<Prev in Thread] Current Thread [Next in Thread>