xfs
[Top] [All Lists]

Re: [PATCH 10/45] fix: force shutdown handling in xfs_end_io

To: xfs@xxxxxxxxxxx
Subject: Re: [PATCH 10/45] fix: force shutdown handling in xfs_end_io
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Sat, 5 Nov 2011 04:11:11 -0400
In-reply-to: <20111028100337.411618173@xxxxxxxxxxxxxxxxxxxxxx>
References: <20111028095423.796574703@xxxxxxxxxxxxxxxxxxxxxx> <20111028100337.411618173@xxxxxxxxxxxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
Btw, this probably is another candidates for 3.2.

On Fri, Oct 28, 2011 at 05:54:33AM -0400, Christoph Hellwig wrote:
> Only ioend->io_error gets propagated back to e.g. AIO completions.
> 
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>
> 
> ---
>  fs/xfs/xfs_aops.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Index: xfs/fs/xfs/xfs_aops.c
> ===================================================================
> --- xfs.orig/fs/xfs/xfs_aops.c        2011-10-27 22:39:56.068672482 +0200
> +++ xfs/fs/xfs/xfs_aops.c     2011-10-27 22:39:56.902173367 +0200
> @@ -184,7 +184,7 @@ xfs_end_io(
>       int             error = 0;
>  
>       if (XFS_FORCED_SHUTDOWN(ip->i_mount)) {
> -             error = -EIO;
> +             ioend->io_error = -EIO;
>               goto done;
>       }
>       if (ioend->io_error)
> 
> _______________________________________________
> xfs mailing list
> xfs@xxxxxxxxxxx
> http://oss.sgi.com/mailman/listinfo/xfs
---end quoted text---

<Prev in Thread] Current Thread [Next in Thread>
  • Re: [PATCH 10/45] fix: force shutdown handling in xfs_end_io, Christoph Hellwig <=