xfs
[Top] [All Lists]

Re: [PATCH 2/2] xfstests: meet btrfs fs size requirement in _scratch_mkf

To: guaneryu@xxxxxxxxx
Subject: Re: [PATCH 2/2] xfstests: meet btrfs fs size requirement in _scratch_mkfs_sized()
From: Stefan Behrens <sbehrens@xxxxxxxxxxxxxxxx>
Date: Fri, 04 Nov 2011 09:21:32 +0100
Cc: Christoph Hellwig <hch@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx, linux-btrfs@xxxxxxxxxxxxxxx
Dkim-signature: v=1; a=rsa-sha1; c=relaxed/relaxed; t=1320394902; l=1756; s=domk; d=giantdisaster.de; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:References: Subject:CC:To:MIME-Version:From:Date:X-RZG-CLASS-ID:X-RZG-AUTH; bh=BrEh5NaC8cYgOcMesy2z4zDnL3g=; b=LcZiTbkwQYFn8UM1aQl2dV/hPPFKqU4qb32C0yftURpnjNnIAn/yYYt6Ok+3dSMs/y/ zzztwGJPwrOFUfqLcf83WrMQBYBGh8DHMRBRJzWH0zSxzHVXc4qAO6Rn38kCHi/cUO6b1 Rm+vplwYs8sQl9dz+Glu3AXoYsXIAqASwqQ=
In-reply-to: <CA+dCu89OZxLx9wCS8511mkRi-uMUDnHFcJQ7yVfR+EL99avcBw@xxxxxxxxxxxxxx>
References: <1320374284-1534-1-git-send-email-guaneryu@xxxxxxxxx> <1320374284-1534-2-git-send-email-guaneryu@xxxxxxxxx> <20111104053908.GB16720@xxxxxxxxxxxxx> <CA+dCu89OZxLx9wCS8511mkRi-uMUDnHFcJQ7yVfR+EL99avcBw@xxxxxxxxxxxxxx>
User-agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:7.0.1) Gecko/20110929 Thunderbird/7.0.1
On 11/4/2011 7:06 AM, Eryu Guan wrote:
> On Fri, Nov 4, 2011 at 1:39 PM, Christoph Hellwig <hch@xxxxxxxxxxxxx> wrote:
>> On Fri, Nov 04, 2011 at 10:38:04AM +0800, Eryu Guan wrote:
>>> btrfs requires at least 256M file system size, so check 'fssize' in
>>> _scratch_mkfs_sized first and give it a proper value. Otherwise
>>> mkfs.btrfs will complain something like
>>>
>>> "File system size 267386880 bytes is too small, 256M is required at least"

Commit bd7d6d45 from Zhong, Xin <xin.zhong@xxxxxxxxx> with date
6/21/2011 removed the 256MB size limitation in mkfs.c in btrfs-progs.


>>>
>>> This makes 015 077 and 083 run on btrfs.
>>
>> But it's not really going to test the ENOSPC conditions it was designed
>> to exercise.  It would be better to either find a way to make btrfs run on
>> smaller filesystem, or call _notrun for too small filesystems on btrfs
>> from _scratch_mkfs_sized.
> 
> Yes, you're right. I checked 015 (it would dd zero to btrfs to full) but 
> forgot
> to check 077 and 083.
> 
> I'll try to find a better way. Thanks for reviewing!
> 
> Eryu Guan
>>
>>>
>>> Signed-off-by: Eryu Guan <guaneryu@xxxxxxxxx>
>>> ---
>>>  common.rc |    5 +++++
>>>  1 files changed, 5 insertions(+), 0 deletions(-)
>>>
>>> diff --git a/common.rc b/common.rc
>>> index e948169..ab61786 100644
>>> --- a/common.rc
>>> +++ b/common.rc
>>> @@ -356,6 +356,11 @@ _scratch_mkfs_sized()
>>>       /sbin/mkfs.$FSTYP $MKFS_OPTIONS -b $blocksize $SCRATCH_DEV $blocks
>>>       ;;
>>>      btrfs)
>>> +    # btrfs needs at least 256M file system size
>>> +     if [ $fssize -lt $((256*1024*1024)) ]
>>> +     then
>>> +             fssize=$((256*1024*1024))
>>> +     fi
>>>       $MKFS_BTRFS_PROG $MKFS_OPTIONS -b $fssize $SCRATCH_DEV
>>>       ;;
>>>      *)
>>> --
>>> 1.7.7.1

<Prev in Thread] Current Thread [Next in Thread>