[Top] [All Lists]

Re: [PATCH 6/8] xfstests: add fiemap operation to fsstress

To: Theodore Tso <tytso@xxxxxxx>, Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH 6/8] xfstests: add fiemap operation to fsstress
From: Dmitry Monakhov <dmonakhov@xxxxxxxxxx>
Date: Thu, 03 Nov 2011 15:04:17 +0400
Cc: Theodore Tso <tytso@xxxxxxx>, linux-fsdevel@xxxxxxxxxxxxxxx, aelder@xxxxxxx, hch@xxxxxx, xfs@xxxxxxxxxxx
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=sender:from:to:cc:subject:in-reply-to:references:user-agent:date :message-id:mime-version:content-type:content-transfer-encoding; bh=bNHOksAqZbqwzWp6bM196NcZfTdqBLvR/eKNxDh4OSM=; b=x+dE80T9BhHeDEDkE1JIWd7hBhQosILLjLM86RjtHtmNPG14IHYJ9USENzBkhiYe6w pny1sHS9iImffcV3ri/I2l0JK2RJmEGhJUB/cy0JFxCz+4JyNxy/A/3CZTfkeNUYGkiV 6pgF9XeTz7ZVz+74yT7ScWgB0CFBEmbgpuRoY=
In-reply-to: <FA2EDC7F-92EC-449E-9FBC-B7955283DFAC@xxxxxxx>
References: <1319849297-3506-1-git-send-email-dmonakhov@xxxxxxxxxx> <1319849297-3506-7-git-send-email-dmonakhov@xxxxxxxxxx> <20111102195534.GB22500@xxxxxxxxxxxxx> <FA2EDC7F-92EC-449E-9FBC-B7955283DFAC@xxxxxxx>
Sender: Dmitry Monakhov <rjevskiy@xxxxxxxxx>
User-agent: Notmuch/0.5-69-g3e4a9d6 (http://notmuchmail.org) Emacs/23.1.1 (i486-pc-linux-gnu)
On Thu, 3 Nov 2011 06:54:16 -0400, Theodore Tso <tytso@xxxxxxx> wrote:
> On Nov 2, 2011, at 3:55 PM, Christoph Hellwig wrote:
> > Alex, Eric, Dave - should we add new tests with the new operations
> > Dmitry added, or is adding new ops to the existing tests fine?
> One argument for adding new ops to existing tests is that it makes the run 
> time of the entire test suite take longer.   A QA pass is already taking 
> quite a while, and it would be nice if we could keep xfstests as efficient as 
> possible in terms of the maximum testing coverage per time spent running the 
> test suite….
Yes, but regression test with explicit seed option should be
preserved. Number of such test is not too big, so it is reasonable to
hardcode set of operations in such tests and let all others use new features.
> -- Ted

<Prev in Thread] Current Thread [Next in Thread>