xfs
[Top] [All Lists]

Re: [PATCH 7/8] xfsdump: path lookup cache must be thread specific

To: Bill Kendall <wkendall@xxxxxxx>
Subject: Re: [PATCH 7/8] xfsdump: path lookup cache must be thread specific
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Thu, 3 Nov 2011 04:33:09 -0400
Cc: xfs@xxxxxxxxxxx
In-reply-to: <1320268254-20583-8-git-send-email-wkendall@xxxxxxx>
References: <1320268254-20583-1-git-send-email-wkendall@xxxxxxx> <1320268254-20583-8-git-send-email-wkendall@xxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Wed, Nov 02, 2011 at 04:10:53PM -0500, Bill Kendall wrote:
> The xfsrestore path lookup routine (maps an ino + generation number to a
> pathname) contains a cache for fast lookups of consecutive files in the
> same parent directory. This cache either needs to be protected by a lock
> or a cache is needed per thread. I took the latter approach since it
> doesn't add lock contention and it increases the cache hit rate (it's
> relatively unlikely that each stream is processing files in the same
> directory).
> 
> Signed-off-by: Bill Kendall <wkendall@xxxxxxx>

Looks good,

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

<Prev in Thread] Current Thread [Next in Thread>