[Top] [All Lists]

Re: [PATCH 2/8] xfsdump: remove multi-stream synchronous dir dump

To: Bill Kendall <wkendall@xxxxxxx>
Subject: Re: [PATCH 2/8] xfsdump: remove multi-stream synchronous dir dump
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Thu, 3 Nov 2011 04:22:48 -0400
Cc: xfs@xxxxxxxxxxx
In-reply-to: <1320268254-20583-3-git-send-email-wkendall@xxxxxxx>
References: <1320268254-20583-1-git-send-email-wkendall@xxxxxxx> <1320268254-20583-3-git-send-email-wkendall@xxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Wed, Nov 02, 2011 at 04:10:48PM -0500, Bill Kendall wrote:
> When doing multi-stream dumps, the directories are dumped by each
> stream in lock-step fashion. A stream backs up a given directory,
> then waits for all others to finish that directory, then they all
> move on to the next one. During restore a single stream is chosen to
> apply the directory dump.
> This patch changes xfsdump so that only one stream dumps the
> directories. The other streams begin dumping files immediately.
> This results in a faster backup, which is presumably why multiple
> streams are being used in the first place.
> It also removes the barrier routines in qlock.c as they were only
> used by the "SYNCDIR" code.
> Signed-off-by: Bill Kendall <wkendall@xxxxxxx>

Looks good,

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

<Prev in Thread] Current Thread [Next in Thread>