xfs
[Top] [All Lists]

Re: [PATCH 3/4] xfs: replace i_pin_wait with a bit waitqueue

To: Alex Elder <aelder@xxxxxxx>
Subject: Re: [PATCH 3/4] xfs: replace i_pin_wait with a bit waitqueue
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Thu, 27 Oct 2011 12:42:29 -0400
Cc: Christoph Hellwig <hch@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx
In-reply-to: <1319663253.5239.75.camel@doink>
References: <20111019182343.762985925@xxxxxxxxxxxxxxxxxxxxxx> <20111019182421.048260722@xxxxxxxxxxxxxxxxxxxxxx> <1319663253.5239.75.camel@doink>
User-agent: Mutt/1.5.21 (2010-09-15)
On Wed, Oct 26, 2011 at 04:07:33PM -0500, Alex Elder wrote:
> > +   xfs_iunpin(ip);
> > +
> 
> This initially struck me as unsafe or something,
> assuming the inode was pinned.  But I was thinking
> of it more like an unlock request, which it is not.
> It's more like unplugging something so the inode
> will eventually get unpinned.  (Just thinking aloud
> here, nevermind me...)

After the next series I am about to post there will be just one caller of
xfs_iunpin left.  We can probably simply fold it at that point.

<Prev in Thread] Current Thread [Next in Thread>