On Tue, 2011-10-25 at 07:54 -0400, Christoph Hellwig wrote:
> Hi Chandra,
> I don't think there is an easy way to add a field there. Please
> just add a new Q_XGETQSTAT_2 call that takes the new, larger structure.
I came up with couple of ideas.
- Add a new version FS_QSTAT_VERSION2 (with a value of 2) that uses
the newer fs_quota_stat
- Start using qs_version in the user space code, with the bigger
- Define a macro to check if the given version is a valid one.
- In xfs_qm_scall_getqstat()(kernel), copy in the newer fs_quota_stat
structure from user space.
If copy in succeeded, check qs_version.
If valid, use the structure relevant to the version.
If invalid, use structure for the version FS_QSTAT_VERSION.
If copy in failed,
use structure for the version FS_QSTAT_VERSION.
I think it should work with the current user space code.
Let me know what you think of it.
Thanks & Regards,
> xfs mailing list