xfs
[Top] [All Lists]

Re: [PATCH 1/8] xfstests: fsstress should kill children tasks before exi

To: Dmitry Monakhov <dmonakhov@xxxxxxxxxx>
Subject: Re: [PATCH 1/8] xfstests: fsstress should kill children tasks before exit
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Mon, 24 Oct 2011 05:06:45 -0400
Cc: linux-fsdevel@xxxxxxxxxxxxxxx, xfs@xxxxxxxxxxx, linux-ext4@xxxxxxxxxxxxxxx, jack@xxxxxxx, hch@xxxxxxxxxxxxx, aelder@xxxxxxx
In-reply-to: <1319020189-13584-2-git-send-email-dmonakhov@xxxxxxxxxx>
References: <1319020189-13584-1-git-send-email-dmonakhov@xxxxxxxxxx> <1319020189-13584-2-git-send-email-dmonakhov@xxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
> +int          should_stop = 0;

this should use sig_atomic_t, or at least volatile.
>  
>  void add_to_flist(int, int, int);
>  void append_pathname(pathname_t *, char *);
> @@ -253,6 +256,10 @@ void     usage(void);
>  void write_freq(void);
>  void zero_freq(void);
>  
> +void sg_handler(int signum) {
> +     should_stop = 1;
> +}

please use normal K&R / Linux style brace placement.

<Prev in Thread] Current Thread [Next in Thread>