xfs
[Top] [All Lists]

Re: [PATCH 3/3] 266: Functional test case for the btrfs raid operations

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH 3/3] 266: Functional test case for the btrfs raid operations
From: Anand Jain <anand.jain@xxxxxxxxxx>
Date: Thu, 20 Oct 2011 23:32:47 +0800
Cc: linux-fsdevel@xxxxxxxxxxxxxxx, linux-btrfs@xxxxxxxxxxxxxxx, xfs@xxxxxxxxxxx, david@xxxxxxxxxxxxx
In-reply-to: <20111019094527.GD3083@xxxxxxxxxxxxx>
Organization: Oracle Corporation
References: <20111013005652.GM3159@dastard> <1318919336-32206-1-git-send-email-Anand.Jain@xxxxxxxxxx> <1318919336-32206-4-git-send-email-Anand.Jain@xxxxxxxxxx> <20111019094527.GD3083@xxxxxxxxxxxxx>
User-agent: Thunderbird 2.0.0.22 (Windows/20090605)

On 19/10/2011 17:45, Christoph Hellwig wrote:
+    if [ $dev_removed == 1 ]; then
+       umount $SCRATCH_MNT
+        _devmgt_add "${DEVHTL}"
+    fi

messy indendation.

 got it. thanks.

+       btrfs filesystem balance $SCRATCH_MNT || _fail "balance failed"
+       #btrfs filesystem show $SCRATCH_DEV 2>&1 | egrep devid |awk '{
+       #       if ( $6 == "0.00" ) { exit 1 }
+       #}' || _fail "test6_add... failed"

what is the point of the commented out code?

otherwise looks good to me.

 yes that has to be removed.

<Prev in Thread] Current Thread [Next in Thread>