xfs
[Top] [All Lists]

Re: [PATCH 3/3] 266: Functional test case for the btrfs raid operations

To: Anand Jain <Anand.Jain@xxxxxxxxxx>
Subject: Re: [PATCH 3/3] 266: Functional test case for the btrfs raid operations
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Wed, 19 Oct 2011 05:45:27 -0400
Cc: hch@xxxxxxxxxxxxx, linux-fsdevel@xxxxxxxxxxxxxxx, linux-btrfs@xxxxxxxxxxxxxxx, xfs@xxxxxxxxxxx, david@xxxxxxxxxxxxx
In-reply-to: <1318919336-32206-4-git-send-email-Anand.Jain@xxxxxxxxxx>
References: <20111013005652.GM3159@dastard> <1318919336-32206-1-git-send-email-Anand.Jain@xxxxxxxxxx> <1318919336-32206-4-git-send-email-Anand.Jain@xxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
> +    if [ $dev_removed == 1 ]; then
> +     umount $SCRATCH_MNT
> +        _devmgt_add "${DEVHTL}"
> +    fi

messy indendation.

> +     btrfs filesystem balance $SCRATCH_MNT || _fail "balance failed"
> +     #btrfs filesystem show $SCRATCH_DEV 2>&1 | egrep devid |awk '{
> +     #       if ( $6 == "0.00" ) { exit 1 }
> +     #}' || _fail "test6_add... failed"

what is the point of the commented out code?

otherwise looks good to me.

<Prev in Thread] Current Thread [Next in Thread>