| To: | Dave Chinner <david@xxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH 1/4] xfs: make i_flags and unsigned long |
| From: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
| Date: | Wed, 19 Oct 2011 04:57:57 -0400 |
| Cc: | Christoph Hellwig <hch@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx |
| In-reply-to: | <20111019003047.GA21338@dastard> |
| References: | <20111018201304.279051318@xxxxxxxxxxxxxxxxxxxxxx> <20111018201405.168458311@xxxxxxxxxxxxxxxxxxxxxx> <20111019003047.GA21338@dastard> |
| User-agent: | Mutt/1.5.21 (2010-09-15) |
On Wed, Oct 19, 2011 at 11:30:47AM +1100, Dave Chinner wrote: > On Tue, Oct 18, 2011 at 04:13:05PM -0400, Christoph Hellwig wrote: > > To be used for bit wakeup i_flags needs to be an unsigned long or we'll > > run into trouble on big endian systems. Beause of the 1-byte i_update > > field right after it this actually causes a fairly large size increase > > on it's own (4 or 7 bytes), but that increase will be more than offset > > by the next two patches. > > You could always make the i_update_core boolean a flag bit, and that > growth will also go away. Regardless: I could. Then again I plan to kill it for 3.3, so re-arranging the deck charis now might not be all that useful. |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH 4/4] xfs: remove the unused dm_attrs structure, Dave Chinner |
|---|---|
| Next by Date: | Re: [PATCH 2/4] xfs: replace i_flock with a sleeping bitlock, Christoph Hellwig |
| Previous by Thread: | Re: [PATCH 1/4] xfs: make i_flags and unsigned long, Dave Chinner |
| Next by Thread: | [PATCH 2/4] xfs: replace i_flock with a sleeping bitlock, Christoph Hellwig |
| Indexes: | [Date] [Thread] [Top] [All Lists] |