[Top] [All Lists]

Re: [PATCH 1/4] xfs: make i_flags and unsigned long

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH 1/4] xfs: make i_flags and unsigned long
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Wed, 19 Oct 2011 11:30:47 +1100
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20111018201405.168458311@xxxxxxxxxxxxxxxxxxxxxx>
References: <20111018201304.279051318@xxxxxxxxxxxxxxxxxxxxxx> <20111018201405.168458311@xxxxxxxxxxxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Tue, Oct 18, 2011 at 04:13:05PM -0400, Christoph Hellwig wrote:
> To be used for bit wakeup i_flags needs to be an unsigned long or we'll
> run into trouble on big endian systems.  Beause of the 1-byte i_update
> field right after it this actually causes a fairly large size increase
> on it's own (4 or 7 bytes), but that increase will be more than offset
> by the next two patches.

You could always make the i_update_core boolean a flag bit, and that
growth will also go away. Regardless:

Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx>

Dave Chinner

<Prev in Thread] Current Thread [Next in Thread>