xfs
[Top] [All Lists]

Re: [RFC PATCH 1/3] Remove in core use of XFS_OQUOTA_ENFD and XFS_OQUOTA

To: xfs@xxxxxxxxxxx
Subject: Re: [RFC PATCH 1/3] Remove in core use of XFS_OQUOTA_ENFD and XFS_OQUOTA_CHKD
From: Arkadiusz Miśkiewicz <arekm@xxxxxxxx>
Date: Tue, 18 Oct 2011 07:16:14 +0200
Cc: Chandra Seetharaman <sekharan@xxxxxxxxxx>
In-reply-to: <20111018000938.14942.44199.sendpatchset@xxxxxxxxxxxxxxxxxxxxxxxxxxxx>
References: <20111018000932.14942.11597.sendpatchset@xxxxxxxxxxxxxxxxxxxxxxxxxxxx> <20111018000938.14942.44199.sendpatchset@xxxxxxxxxxxxxxxxxxxxxxxxxxxx>
User-agent: KMail/1.13.7 (Linux/3.1.0-rc9-00087-g4c41042-dirty; KDE/4.7.2; x86_64; ; )
On Tuesday 18 of October 2011, Chandra Seetharaman wrote:

Quick look for diff between your and mine patch when I was playing with 
separate project quota some time ago and:

> diff --git a/fs/xfs/xfs_qm_syscalls.c b/fs/xfs/xfs_qm_syscalls.c
> index 5cc3dde..3a67805 100644
> --- a/fs/xfs/xfs_qm_syscalls.c
> +++ b/fs/xfs/xfs_qm_syscalls.c
> @@ -120,11 +120,11 @@ xfs_qm_scall_quotaoff(
>       }
>       if (flags & XFS_GQUOTA_ACCT) {
>               dqtype |= XFS_QMOPT_GQUOTA;
> -             flags |= (XFS_OQUOTA_CHKD | XFS_OQUOTA_ENFD);
> +             flags |= (XFS_GQUOTA_CHKD | XFS_GQUOTA_ENFD);
>               inactivate_flags |= XFS_GQUOTA_ACTIVE;
>       } else if (flags & XFS_PQUOTA_ACCT) {

These can be separate so, no else if but just separate if.


> diff --git a/fs/xfs/xfs_super.c b/fs/xfs/xfs_super.c
> index ba16248..b1c8d5b 100644
> --- a/fs/xfs/xfs_super.c
> +++ b/fs/xfs/xfs_super.c

> @@ -552,12 +553,12 @@ xfs_showargs(
>       /* Either project or group quotas can be active, not both */

No longer true.

> 
>       if (mp->m_qflags & XFS_PQUOTA_ACCT) {
> -             if (mp->m_qflags & XFS_OQUOTA_ENFD)
> +             if (mp->m_qflags & XFS_PQUOTA_ENFD)
>                       seq_puts(m, "," MNTOPT_PRJQUOTA);
>               else
>                       seq_puts(m, "," MNTOPT_PQUOTANOENF);
>       } else if (mp->m_qflags & XFS_GQUOTA_ACCT) {

Also not else if - just if.

> -             if (mp->m_qflags & XFS_OQUOTA_ENFD)
> +             if (mp->m_qflags & XFS_GQUOTA_ENFD)

-- 
Arkadiusz Miśkiewicz        PLD/Linux Team
arekm / maven.pl            http://ftp.pld-linux.org/

<Prev in Thread] Current Thread [Next in Thread>