On Mon, 2011-10-10 at 13:14 +1100, Dave Chinner wrote:
> From: Dave Chinner <dchinner@xxxxxxxxxx>
> The xfs_bmap output in the golden image is filesystem block size
> dependent. Make all writes 64k to ensure that the allocation/hole
> pattern is consistent across all supported filesystem block sizes.
> Also, use the SCRATCH_DEV instead of the TEST_DEV so that we test
> according to MKFS_OPTIONS rather than test on whatever setup the
> TEST_DEV was created with.
> Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx>
A minor thing below, which I'll fix for you.
Also one question. Otherwise looks good.
Reviewed-by: Alex Elder <aelder@xxxxxxx>
. . .
> - rm -f $TEST_DIR/hole_file*
You no longer delete the hole files because there's
no need to (because scratch will likely be clobbered
> - rm -f $TEST_DIR/r??
> + rm -f $SCRATCH_DIR/r??
(This is an annoyance that ought to be fixed everywhere
I think--either make it SCRATCH_DIR or TEST_MNT.)
. . .