xfs
[Top] [All Lists]

Re: [PATCH 2/2] xfstests: make 203 pass on non-default block size filesy

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 2/2] xfstests: make 203 pass on non-default block size filesystems
From: Alex Elder <aelder@xxxxxxx>
Date: Thu, 13 Oct 2011 05:35:34 -0500
Cc: <xfs@xxxxxxxxxxx>
In-reply-to: <1318212855-20212-3-git-send-email-david@xxxxxxxxxxxxx>
References: <1318212855-20212-1-git-send-email-david@xxxxxxxxxxxxx> <1318212855-20212-3-git-send-email-david@xxxxxxxxxxxxx>
Reply-to: <aelder@xxxxxxx>
On Mon, 2011-10-10 at 13:14 +1100, Dave Chinner wrote:
> From: Dave Chinner <dchinner@xxxxxxxxxx>
> 
> The xfs_bmap output in the golden image is filesystem block size
> dependent. Make all writes 64k to ensure that the allocation/hole
> pattern is consistent across all supported filesystem block sizes.
> 
> Also, use the SCRATCH_DEV instead of the TEST_DEV so that we test
> according to MKFS_OPTIONS rather than test on whatever setup the
> TEST_DEV was created with.
> 
> Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx>

A minor thing below, which I'll fix for you.
Also one question.  Otherwise looks good.

Reviewed-by: Alex Elder <aelder@xxxxxxx>

. . .
>  _cleanup()
>  {
> -     rm -f $TEST_DIR/hole_file*

You no longer delete the hole files because there's
no need to (because scratch will likely be clobbered
anyway)?

> -     rm -f $TEST_DIR/r??
> +     rm -f $SCRATCH_DIR/r??

SCRATCH_MNT

(This is an annoyance that ought to be fixed everywhere
I think--either make it SCRATCH_DIR or TEST_MNT.)

. . .


<Prev in Thread] Current Thread [Next in Thread>