| To: | Dave Chinner <david@xxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH 3/5] repair: handle memory allocation failure from blkmap_grow |
| From: | Alex Elder <aelder@xxxxxxx> |
| Date: | Thu, 13 Oct 2011 04:57:54 -0500 |
| Cc: | <xfs@xxxxxxxxxxx> |
| In-reply-to: | <1318208915-14975-4-git-send-email-david@xxxxxxxxxxxxx> |
| References: | <1318208915-14975-1-git-send-email-david@xxxxxxxxxxxxx> <1318208915-14975-4-git-send-email-david@xxxxxxxxxxxxx> |
| Reply-to: | <aelder@xxxxxxx> |
On Mon, 2011-10-10 at 12:08 +1100, Dave Chinner wrote: > From: Dave Chinner <dchinner@xxxxxxxxxx> > > If blkmap_grow fails to allocate a new chunk of memory, it returns > with a null blkmap. The sole caller of blkmap_grow does not check > for this failure, and so will segfault if this error ever occurs. > > Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx> Looks good. Reviewed-by: Alex Elder <aelder@xxxxxxx> |
| Previous by Date: | Re: [PATCH 2/5] repair: fix a valgrind reported error on i686, Alex Elder |
|---|---|
| Next by Date: | Re: [PATCH 4/5] repair: don't cache large blkmap allocations, Alex Elder |
| Previous by Thread: | Re: [PATCH 3/5] repair: handle memory allocation failure from blkmap_grow, Christoph Hellwig |
| Next by Thread: | [PATCH 4/5] repair: don't cache large blkmap allocations, Dave Chinner |
| Indexes: | [Date] [Thread] [Top] [All Lists] |