xfs
[Top] [All Lists]

Re: [PATCH 2/5] repair: fix a valgrind reported error on i686

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 2/5] repair: fix a valgrind reported error on i686
From: Alex Elder <aelder@xxxxxxx>
Date: Thu, 13 Oct 2011 04:57:52 -0500
Cc: <xfs@xxxxxxxxxxx>
In-reply-to: <1318208915-14975-3-git-send-email-david@xxxxxxxxxxxxx>
References: <1318208915-14975-1-git-send-email-david@xxxxxxxxxxxxx> <1318208915-14975-3-git-send-email-david@xxxxxxxxxxxxx>
Reply-to: <aelder@xxxxxxx>
On Mon, 2011-10-10 at 12:08 +1100, Dave Chinner wrote:
> From: Dave Chinner <dchinner@xxxxxxxxxx>
> 
> Fix a potential prefetch read problem due to the first loop
> execution of pf_batch_read potentially not initialising the fsbno
> variable:
> 
> ==10177== Thread 6:
> ==10177== Conditional jump or move depends on uninitialised value(s)
> ==10177==    at 0x8079CAB: pf_batch_read (prefetch.c:408)
> ==10177==    by 0x6A2996D: clone (clone.S:130)
> ==10177==
> 
> Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx>

Looks good.

Reviewed-by: Alex Elder <aelder@xxxxxxx>


<Prev in Thread] Current Thread [Next in Thread>