xfs
[Top] [All Lists]

Re: [PATCH 11/11] xfs: do not flush data workqueues in xfs_flush_buftarg

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH 11/11] xfs: do not flush data workqueues in xfs_flush_buftarg
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Wed, 12 Oct 2011 09:35:25 +1100
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20111010165328.386947740@xxxxxxxxxxxxxxxxxxxxxx>
References: <20111010165242.656850411@xxxxxxxxxxxxxxxxxxxxxx> <20111010165328.386947740@xxxxxxxxxxxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Mon, Oct 10, 2011 at 12:52:53PM -0400, Christoph Hellwig wrote:
> When we call xfs_flush_buftarg (generally from sync or umount) it already
> is too late to flush the data workqueues, as I/O completion is signalled
> for them and we are thus already done with the data we would flush here.
> 
> There are places where flushing them might be useful, but the current
> sync interface doesn't give us that opportunity.
> 
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>

Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx>

-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>