| To: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH 11/11] xfs: do not flush data workqueues in xfs_flush_buftarg |
| From: | Alex Elder <aelder@xxxxxxx> |
| Date: | Tue, 11 Oct 2011 14:04:31 -0500 |
| Cc: | <xfs@xxxxxxxxxxx> |
| In-reply-to: | <20111010165328.386947740@xxxxxxxxxxxxxxxxxxxxxx> |
| References: | <20111010165242.656850411@xxxxxxxxxxxxxxxxxxxxxx> <20111010165328.386947740@xxxxxxxxxxxxxxxxxxxxxx> |
| Reply-to: | <aelder@xxxxxxx> |
On Mon, 2011-10-10 at 12:52 -0400, Christoph Hellwig wrote: > When we call xfs_flush_buftarg (generally from sync or umount) it already > is too late to flush the data workqueues, as I/O completion is signalled > for them and we are thus already done with the data we would flush here. > > There are places where flushing them might be useful, but the current > sync interface doesn't give us that opportunity. > > Signed-off-by: Christoph Hellwig <hch@xxxxxx> Looks OK to me. Reviewed-by: Alex Elder <aelder@xxxxxxx> |
| Previous by Date: | Re: 2.6.38.8 kernel bug in XFS or megaraid driver with heavy I/O load, Jesper Krogh |
|---|---|
| Next by Date: | [XFS updates] XFS development tree branch, for-linus, updated. v3.1-rc3-1147-g8e749e3, xfs |
| Previous by Thread: | Re: [PATCH 11/11] xfs: do not flush data workqueues in xfs_flush_buftarg, Alex Elder |
| Next by Thread: | Re: [PATCH 11/11] xfs: do not flush data workqueues in xfs_flush_buftarg, Dave Chinner |
| Indexes: | [Date] [Thread] [Top] [All Lists] |