xfs
[Top] [All Lists]

[PATCH 1/4] xfs: do not update xa_last_pushed_lsn for locked items

To: xfs@xxxxxxxxxxx
Subject: [PATCH 1/4] xfs: do not update xa_last_pushed_lsn for locked items
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Tue, 11 Oct 2011 11:14:08 -0400
References: <20111011151407.382514375@xxxxxxxxxxxxxxxxxxxxxx>
User-agent: quilt/0.48-1
If an item was locked we should not update xa_last_pushed_lsn and thus skip
it when restarting the AIL scan as we need to be able to lock and write it
out as soon as possible.  Otherwise heavy lock contention might starve AIL
pushing too easily, especially given the larger backoff once we moved
xa_last_pushed_lsn all the way to the target lsn.

Signed-off-by: Christoph Hellwig <hch@xxxxxx>
Reported-by: Stefan Priebe <s.priebe@xxxxxxxxxxxx>
Tested-by: Stefan Priebe <s.priebe@xxxxxxxxxxxx>

Index: xfs/fs/xfs/xfs_trans_ail.c
===================================================================
--- xfs.orig/fs/xfs/xfs_trans_ail.c     2011-10-11 15:48:49.302003241 +0200
+++ xfs/fs/xfs/xfs_trans_ail.c  2011-10-11 15:49:10.307505812 +0200
@@ -440,7 +440,6 @@ xfs_ail_worker(
 
                case XFS_ITEM_LOCKED:
                        XFS_STATS_INC(xs_push_ail_locked);
-                       ailp->xa_last_pushed_lsn = lsn;
                        stuck++;
                        break;
 

<Prev in Thread] Current Thread [Next in Thread>