xfs
[Top] [All Lists]

Re: [PATCH 11/11] xfs: do not flush data workqueues in xfs_flush_buftarg

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH 11/11] xfs: do not flush data workqueues in xfs_flush_buftarg
From: Alex Elder <aelder@xxxxxxx>
Date: Mon, 10 Oct 2011 23:04:14 -0500
Cc: <xfs@xxxxxxxxxxx>
In-reply-to: <20111010165328.386947740@xxxxxxxxxxxxxxxxxxxxxx>
References: <20111010165242.656850411@xxxxxxxxxxxxxxxxxxxxxx> <20111010165328.386947740@xxxxxxxxxxxxxxxxxxxxxx>
Reply-to: <aelder@xxxxxxx>
On Mon, 2011-10-10 at 12:52 -0400, Christoph Hellwig wrote:
> plain text document attachment
> (xfs-stop-flushing-data-wqs-in-xfs_flush_buftarg)
> When we call xfs_flush_buftarg (generally from sync or umount) it already
> is too late to flush the data workqueues, as I/O completion is signalled
> for them and we are thus already done with the data we would flush here.
> 
> There are places where flushing them might be useful, but the current
> sync interface doesn't give us that opportunity.
> 
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>

This looks fine to me for now but I'm going to review it
again in the morning.  I'll be testing with it overnight
though.

                                        -Alex

<Prev in Thread] Current Thread [Next in Thread>