xfs
[Top] [All Lists]

Re: [PATCH 3/3] xfstests: allow 091 for non-xfs filesystems

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH 3/3] xfstests: allow 091 for non-xfs filesystems
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Tue, 11 Oct 2011 13:11:32 +1100
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20111010182233.GB1335@xxxxxxxxxxxxx>
References: <20111010182156.GA1323@xxxxxxxxxxxxx> <20111010182216.GA1335@xxxxxxxxxxxxx> <20111010182233.GB1335@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Mon, Oct 10, 2011 at 02:22:33PM -0400, Christoph Hellwig wrote:
> The tests in 091 are entirely generic and pass e.g. on ext4 and jfs.
> btrfs fails it, but that looks a like a btrfs-specific issue to me.
> 
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>
> 
> Index: xfstests-dev/091
> ===================================================================
> --- xfstests-dev.orig/091     2011-10-10 18:09:20.000000000 +0000
> +++ xfstests-dev/091  2011-10-10 18:09:41.000000000 +0000
> @@ -37,7 +37,7 @@ trap "rm -f $tmp.*; exit \$status" 0 1 2
>  . ./common.filter
>  
>  # real QA test starts here
> -_supported_fs xfs
> +_supported_fs generic
>  _supported_os Linux IRIX
>  
>  [ $HOSTOS == IRIX ] && _notrun "Not working on IRIX yet"

Given that the test is not run on irix, I'd change the _supported_os
line to just Linux as well, and kill the separate check for Irix
while you are there.

Cheers,

Dave.

-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>