xfs
[Top] [All Lists]

Re: [PATCH 1/4] xfs: do not update xa_last_pushed_lsn for locked items

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH 1/4] xfs: do not update xa_last_pushed_lsn for locked items
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Mon, 10 Oct 2011 12:37:49 +1100
Cc: xfs@xxxxxxxxxxx, Stefan Priebe <s.priebe@xxxxxxxxxxxx>
In-reply-to: <20111006183549.399127499@xxxxxxxxxxxxxxxxxxxxxx>
References: <20111006183257.036884724@xxxxxxxxxxxxxxxxxxxxxx> <20111006183549.399127499@xxxxxxxxxxxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Thu, Oct 06, 2011 at 02:32:58PM -0400, Christoph Hellwig wrote:
> If an item was locked we should not update xa_last_pushed_lsn and thus skip
> it when restarting the AIL scan as we need to be able to lock and write it
> out as soon as possible.  Otherwise heavy lock contention might starve AIL
> pushing too easily, especially given the larger backoff once we moved
> xa_last_pushed_lsn all the way to the target lsn.
> 
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>
> Reported-by: Stefan Priebe <s.priebe@xxxxxxxxxxxx>
> Tested-by: Stefan Priebe <s.priebe@xxxxxxxxxxxx>

Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx>
-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>