| To: | xfs@xxxxxxxxxxx |
|---|---|
| Subject: | [PATCH 2/5] repair: fix a valgrind reported error on i686 |
| From: | Dave Chinner <david@xxxxxxxxxxxxx> |
| Date: | Mon, 10 Oct 2011 12:08:32 +1100 |
| In-reply-to: | <1318208915-14975-1-git-send-email-david@xxxxxxxxxxxxx> |
| References: | <1318208915-14975-1-git-send-email-david@xxxxxxxxxxxxx> |
From: Dave Chinner <dchinner@xxxxxxxxxx>
Fix a potential prefetch read problem due to the first loop
execution of pf_batch_read potentially not initialising the fsbno
variable:
==10177== Thread 6:
==10177== Conditional jump or move depends on uninitialised value(s)
==10177== at 0x8079CAB: pf_batch_read (prefetch.c:408)
==10177== by 0x6A2996D: clone (clone.S:130)
==10177==
Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx>
---
repair/prefetch.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/repair/prefetch.c b/repair/prefetch.c
index d2fdf90..da074a8 100644
--- a/repair/prefetch.c
+++ b/repair/prefetch.c
@@ -397,7 +397,7 @@ pf_batch_read(
int len, size;
int i;
int inode_bufs;
- unsigned long fsbno;
+ unsigned long fsbno = 0;
unsigned long max_fsbno;
char *pbuf;
--
1.7.5.4
|
| Previous by Date: | [PATCH 5/5] repair: prevent blkmap extent count overflows, Dave Chinner |
|---|---|
| Next by Date: | [PATCH 3/5] repair: handle memory allocation failure from blkmap_grow, Dave Chinner |
| Previous by Thread: | Re: [PATCH 5/5] repair: prevent blkmap extent count overflows, Alex Elder |
| Next by Thread: | Re: [PATCH 2/5] repair: fix a valgrind reported error on i686, Christoph Hellwig |
| Indexes: | [Date] [Thread] [Top] [All Lists] |