| To: | Dave Chinner <david@xxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH 4/5] repair: don't cache large blkmap allocations |
| From: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
| Date: | Sun, 9 Oct 2011 19:48:09 -0400 |
| Cc: | xfs@xxxxxxxxxxx |
| In-reply-to: | <1318201910-11144-5-git-send-email-david@xxxxxxxxxxxxx> |
| References: | <1318201910-11144-1-git-send-email-david@xxxxxxxxxxxxx> <1318201910-11144-5-git-send-email-david@xxxxxxxxxxxxx> |
| User-agent: | Mutt/1.5.21 (2010-09-15) |
> + /* consider more than 100k extents rare */ > + if (blkmap->naexts < 100 * 1024) > + return; 100k extents still seems like a fairly high number. Otherwise looks okay. (If only we had a non-sucky threaded memory allocator in userspace..) |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH 2/5] repair: fix some valgrind reported errors on i686, Christoph Hellwig |
|---|---|
| Next by Date: | Re: [PATCH 3/5] repair: handle memory allocation failure from blkmap_grow, Christoph Hellwig |
| Previous by Thread: | [PATCH 4/5] repair: don't cache large blkmap allocations, Dave Chinner |
| Next by Thread: | Re: [PATCH 4/5] repair: don't cache large blkmap allocations, Dave Chinner |
| Indexes: | [Date] [Thread] [Top] [All Lists] |