xfs
[Top] [All Lists]

Re: [PATCH 4/5] repair: don't cache large blkmap allocations

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 4/5] repair: don't cache large blkmap allocations
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Sun, 9 Oct 2011 19:48:09 -0400
Cc: xfs@xxxxxxxxxxx
In-reply-to: <1318201910-11144-5-git-send-email-david@xxxxxxxxxxxxx>
References: <1318201910-11144-1-git-send-email-david@xxxxxxxxxxxxx> <1318201910-11144-5-git-send-email-david@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
> +     /* consider more than 100k extents rare */
> +     if (blkmap->naexts < 100 * 1024)
> +             return;

100k extents still seems like a fairly high number.  Otherwise looks
okay.

(If only we had a non-sucky threaded memory allocator in userspace..)

<Prev in Thread] Current Thread [Next in Thread>