| To: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH 2/4] xfs: force the log if we encounter pinned buffers in .iop_pushbuf |
| From: | Alex Elder <aelder@xxxxxxx> |
| Date: | Fri, 7 Oct 2011 17:18:11 -0500 |
| Cc: | <xfs@xxxxxxxxxxx>, Stefan Priebe <s.priebe@xxxxxxxxxxxx> |
| In-reply-to: | <20111006183549.598050900@xxxxxxxxxxxxxxxxxxxxxx> |
| References: | <20111006183257.036884724@xxxxxxxxxxxxxxxxxxxxxx> <20111006183549.598050900@xxxxxxxxxxxxxxxxxxxxxx> |
| Reply-to: | <aelder@xxxxxxx> |
On Thu, 2011-10-06 at 14:32 -0400, Christoph Hellwig wrote: > We need to check for pinned buffers even in .iop_pushbuf given that inode > items flush into the same buffers that may be pinned directly due operations > on the unlinked inode list operating directly on buffers. To do this add a > return value to .iop_pushbuf that tells the AIL push about this and use > the existing log force mechanisms to unpin it. > > Signed-off-by: Christoph Hellwig <hch@xxxxxx> > Reported-by: Stefan Priebe <s.priebe@xxxxxxxxxxxx> > Tested-by: Stefan Priebe <s.priebe@xxxxxxxxxxxx> Looks ok to me. Reviewed-by: Alex Elder <aelder@xxxxxxx> |
| Previous by Date: | Re: [PATCH 1/4] xfs: do not update xa_last_pushed_lsn for locked items, Alex Elder |
|---|---|
| Next by Date: | Re: [PATCH 3/4] xfs: revert to using a kthread for AIL pushing, Alex Elder |
| Previous by Thread: | [PATCH 2/4] xfs: force the log if we encounter pinned buffers in .iop_pushbuf, Christoph Hellwig |
| Next by Thread: | Re: [PATCH 2/4] xfs: force the log if we encounter pinned buffers in .iop_pushbuf, Dave Chinner |
| Indexes: | [Date] [Thread] [Top] [All Lists] |