[Top] [All Lists]

Re: [PATCH 9/9] xfs: remove xfs_buf_target_name

To: Alex Elder <aelder@xxxxxxx>
Subject: Re: [PATCH 9/9] xfs: remove xfs_buf_target_name
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Fri, 7 Oct 2011 16:10:01 -0400
Cc: xfs@xxxxxxxxxxx
In-reply-to: <1318016243.2810.47.camel@doink>
References: <20111006210607.175284390@xxxxxxxxxxxxxxxxxxxxxx> <20111006210640.089607475@xxxxxxxxxxxxxxxxxxxxxx> <1318016243.2810.47.camel@doink>
User-agent: Mutt/1.5.21 (2010-09-15)
On Fri, Oct 07, 2011 at 02:37:23PM -0500, Alex Elder wrote:
> On Thu, 2011-10-06 at 17:06 -0400, Christoph Hellwig wrote:
> > The calling convention that returns a pointer to a static buffer is
> > fairly nasty, so just opencode it in the only caller that is left.
> > 
> > Signed-off-by: Christoph Hellwig <hch@xxxxxx>
> Yay!  The name buffer needs not to be static any more though.
> I will remove it for you unless you want to re-post it.
> Other than that, looks good.

I'll resping the series with this and the naming change.

<Prev in Thread] Current Thread [Next in Thread>