[Top] [All Lists]

Re: [PATCH 9/9] xfs: remove xfs_buf_target_name

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH 9/9] xfs: remove xfs_buf_target_name
From: Alex Elder <aelder@xxxxxxx>
Date: Fri, 7 Oct 2011 14:37:23 -0500
Cc: <xfs@xxxxxxxxxxx>
In-reply-to: <20111006210640.089607475@xxxxxxxxxxxxxxxxxxxxxx>
References: <20111006210607.175284390@xxxxxxxxxxxxxxxxxxxxxx> <20111006210640.089607475@xxxxxxxxxxxxxxxxxxxxxx>
Reply-to: <aelder@xxxxxxx>
On Thu, 2011-10-06 at 17:06 -0400, Christoph Hellwig wrote:
> The calling convention that returns a pointer to a static buffer is
> fairly nasty, so just opencode it in the only caller that is left.
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>

Yay!  The name buffer needs not to be static any more though.
I will remove it for you unless you want to re-post it.

Other than that, looks good.

Reviewed-by: Alex Elder <aelder@xxxxxxx>

<Prev in Thread] Current Thread [Next in Thread>