xfs
[Top] [All Lists]

Re: [PATCH 5/9] xfs: remove buffers from the delwri list in xfs_buf_stal

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH 5/9] xfs: remove buffers from the delwri list in xfs_buf_stale
From: Alex Elder <aelder@xxxxxxx>
Date: Fri, 7 Oct 2011 14:36:59 -0500
Cc: <xfs@xxxxxxxxxxx>
In-reply-to: <20111006210639.352441913@xxxxxxxxxxxxxxxxxxxxxx>
References: <20111006210607.175284390@xxxxxxxxxxxxxxxxxxxxxx> <20111006210639.352441913@xxxxxxxxxxxxxxxxxxxxxx>
Reply-to: <aelder@xxxxxxx>
On Thu, 2011-10-06 at 17:06 -0400, Christoph Hellwig wrote:
> For each call to xfs_buf_stale we call xfs_buf_delwri_dequeue either
> directly before or after it, or are guaranteed by the surrounding
> conditionals that we are never called on delwri buffers.  Simply
> this situation by moving the call to xfs_buf_delwri_dequeue into
> xfs_buf_stale.
> 
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>

I see 6 or so spots where xfs_buf_stale() is (was) called with no call
to xfs_buf_delwri_dequeue().  This adds such a call, but it looks to me
like that's OK.

Looks good.

Reviewed-by: Alex Elder <aelder@xxxxxxx>


<Prev in Thread] Current Thread [Next in Thread>