| To: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH 5/9] xfs: remove buffers from the delwri list in xfs_buf_stale |
| From: | Dave Chinner <david@xxxxxxxxxxxxx> |
| Date: | Fri, 7 Oct 2011 12:45:36 +1100 |
| Cc: | xfs@xxxxxxxxxxx |
| In-reply-to: | <20111006210639.352441913@xxxxxxxxxxxxxxxxxxxxxx> |
| References: | <20111006210607.175284390@xxxxxxxxxxxxxxxxxxxxxx> <20111006210639.352441913@xxxxxxxxxxxxxxxxxxxxxx> |
| User-agent: | Mutt/1.5.21 (2010-09-15) |
On Thu, Oct 06, 2011 at 05:06:12PM -0400, Christoph Hellwig wrote: > For each call to xfs_buf_stale we call xfs_buf_delwri_dequeue either > directly before or after it, or are guaranteed by the surrounding > conditionals that we are never called on delwri buffers. Simply > this situation by moving the call to xfs_buf_delwri_dequeue into > xfs_buf_stale. Makes sense, and delwri-dequeue is safe to call on non-delwri buffers. Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx> -- Dave Chinner david@xxxxxxxxxxxxx |
| Previous by Date: | Re: [PATCH 4/9] xfs: remove XFS_BUF_STALE and XFS_BUF_SUPER_STALE, Dave Chinner |
|---|---|
| Next by Date: | Re: [PATCH 6/9] xfs: clean up buffer allocation, Dave Chinner |
| Previous by Thread: | [PATCH 5/9] xfs: remove buffers from the delwri list in xfs_buf_stale, Christoph Hellwig |
| Next by Thread: | Re: [PATCH 5/9] xfs: remove buffers from the delwri list in xfs_buf_stale, Alex Elder |
| Indexes: | [Date] [Thread] [Top] [All Lists] |