xfs
[Top] [All Lists]

Re: [PATCH] xfstests: 261: test failures caused by bogus mtab entries

To: Alex Elder <aelder@xxxxxxx>
Subject: Re: [PATCH] xfstests: 261: test failures caused by bogus mtab entries
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Thu, 6 Oct 2011 15:49:13 -0400
Cc: xfs@xxxxxxxxxxx
In-reply-to: <201110032301.p93N1ISR023771@xxxxxxxxxxxxxxxxxxxxxx>
References: <201110032301.p93N1ISR023771@xxxxxxxxxxxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
> +mtab=/proc/self/mounts
> +if [ ! -r "${mtab}" ]; then
> +    mtab=/etc/mtab
> +    if [ ! -r "${mtab}" ]; then
> +     echo "warning: proceeding without use of mount table" >&2
> +    fi
> +fi

Just use /proc/self/mounts unconditionally, it's been there for a long
time.

Otherwise looks good,

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

<Prev in Thread] Current Thread [Next in Thread>