xfs
[Top] [All Lists]

Re: [PATCH 4/6] xfsprogs: libxcmd: isolate strdup() calls to fs_table_in

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH 4/6] xfsprogs: libxcmd: isolate strdup() calls to fs_table_insert()
From: Alex Elder <aelder@xxxxxxx>
Date: Thu, 6 Oct 2011 14:47:52 -0500
Cc: <xfs@xxxxxxxxxxx>
In-reply-to: <20111006194514.GB13434@xxxxxxxxxxxxx>
References: <4a7a9e630aa7c62357a606f762abc19fc1d7073b.1317646036.git.aelder@xxxxxxx> <0f871eebf39384818415253082320f860739f113.1317646036.git.aelder@xxxxxxx> <20111006194514.GB13434@xxxxxxxxxxxxx>
Reply-to: <aelder@xxxxxxx>
On Thu, 2011-10-06 at 15:45 -0400, Christoph Hellwig wrote:
...

> If you touch these anyway please move assignments outside the
> conditionals, e.g.

OK.  No problem.  I was opting for less indent depth
but *almost* did what you say in the first place...

                                        -Alex

<Prev in Thread] Current Thread [Next in Thread>