Re: [PATCH] xfstests: make 258 more forgiving of timestamp rounding

xfs

Re: [PATCH] xfstests: make 258 more forgiving of timestamp rounding

To:	Eric Sandeen <sandeen@xxxxxxxxxx>
Subject:	Re: [PATCH] xfstests: make 258 more forgiving of timestamp rounding
From:	Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date:	Thu, 6 Oct 2011 15:47:38 -0400
Cc:	xfs-oss <xfs@xxxxxxxxxxx>
In-reply-to:	<4E89E851.80203@xxxxxxxxxx>
References:	<4E89E851.80203@xxxxxxxxxx>
User-agent:	Mutt/1.5.21 (2010-09-15)

On Mon, Oct 03, 2011 at 11:52:33AM -0500, Eric Sandeen wrote:
> Rather than testing for an exact timestamp, which could vary
> due to rounding, just check that it is not positive,
> which is the failure case we're looking for.
> 
> Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxx>

Looks good,

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
[PATCH] xfstests: make 258 more forgiving of timestamp rounding, Eric Sandeen Re: [PATCH] xfstests: make 258 more forgiving of timestamp rounding, Alex Elder Re: [PATCH] xfstests: make 258 more forgiving of timestamp rounding, Christoph Hellwig <=

Previous by Date:	Re: [PATCH 6/6] xfsprogs: libxcmd: ignore errors when initializing fs_table, Christoph Hellwig
Next by Date:	Re: [PATCH 4/6] xfsprogs: libxcmd: isolate strdup() calls to fs_table_insert(), Alex Elder
Previous by Thread:	Re: [PATCH] xfstests: make 258 more forgiving of timestamp rounding, Alex Elder
Next by Thread:	[PATCH] xfstests: 261: test failures caused by bogus mtab entries, Alex Elder
Indexes:	[Date] [Thread] [Top] [All Lists]