xfs
[Top] [All Lists]

Re: [PATCH 1/2] repair: handle repair of image files on large sector siz

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 1/2] repair: handle repair of image files on large sector size filesystems
From: Alex Elder <aelder@xxxxxxx>
Date: Thu, 6 Oct 2011 07:17:45 -0500
Cc: <xfs@xxxxxxxxxxx>
In-reply-to: <1317862891-3033-2-git-send-email-david@xxxxxxxxxxxxx>
References: <1317862891-3033-1-git-send-email-david@xxxxxxxxxxxxx> <1317862891-3033-2-git-send-email-david@xxxxxxxxxxxxx>
Reply-to: <aelder@xxxxxxx>
On Thu, 2011-10-06 at 12:01 +1100, Dave Chinner wrote:
> From: Dave Chinner <dchinner@xxxxxxxxxx>
> 
> Because repair uses direct IO, it cannot do IO smaller than a sector
> on the underlying device. When repairing a filesystem image, the
> filesystem hosting the image may have a sector size larger than the
> sector size of the image, and so single image sector reads and
> writes will fail.
> 
> To avoid this, when checking a file and there is a sector size
> mismatch like this, turn off direct IO. While there, fix a compile
> bug in the IO_DEBUG option for libxfs which was found during triage.
> 
> Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx>

I had a few suggestions for you to consider when I
reviewed this before.  The second patch in this series
needs an update so you have a chance to address those
suggestions if you so choose.

    http://patchwork.xfs.org/patch/2336/

Either way, I'll mark this as I did before.

Reviewed-by: Alex Elder <aelder@xxxxxxx>


<Prev in Thread] Current Thread [Next in Thread>