xfs
[Top] [All Lists]

Re: [PATCH 1/2] xfstest: fsstress should kill children tasks before exit

To: Dmitry Monakhov <dmonakhov@xxxxxxxxxx>
Subject: Re: [PATCH 1/2] xfstest: fsstress should kill children tasks before exit
From: Alex Elder <aelder@xxxxxxx>
Date: Wed, 5 Oct 2011 08:20:38 -0500
Cc: <xfs@xxxxxxxxxxx>, <linux-ext4@xxxxxxxxxxxxxxx>, <linux-fsdevel@xxxxxxxxxxxxxxx>
In-reply-to: <1316357699-22692-1-git-send-email-dmonakhov@xxxxxxxxxx>
References: <1316357699-22692-1-git-send-email-dmonakhov@xxxxxxxxxx>
Reply-to: <aelder@xxxxxxx>
On Sun, 2011-09-18 at 18:54 +0400, Dmitry Monakhov wrote:
> It is very hard to predict runtime for fsstress. In many cases it
> is useful to give test to run a reasonable time, and then kill it.
> But currently there is no reliable way to kill test without leaving
> running children.
> This patch add sanity cleanup logic which looks follow:
>  - On sigterm received by parent, it resend signal to it's children
>  - Wait for each child to terminates
>  - EXTRA_SANITY: Even if parent was killed by other signal, children
>    will be terminated with SIGKILL to preven staled children.
> 
> So now one can simply run fsstress like this:
> ./fsstress -p 1000 -n999999999 -d $TEST_DIR &
> PID=$!
> sleep 300
> kill $PID
> wait $PID
> 
> Signed-off-by: Dmitry Monakhov <dmonakhov@xxxxxxxxxx>

I think this is an interesting change and it looks
OK to me.  I agree with Christoph's suggestion (on
the second patch in this series) that it would be
nice to have at least one of the tests make use of
it, if nothing else just to document that it's a
reasonable thing to do.

But even without that I think this is both useful
and harmless.

Reviewed-by: Alex Elder <aelder@xxxxxxx>


<Prev in Thread] Current Thread [Next in Thread>