On Mon, Oct 03, 2011 at 09:21:25AM -0500, Alex Elder wrote:
> > I'd really like to do some sort of QA for this. Given that xfs_quota
> > already has an (uncodumented) -t flag to use a replacement for
> > /proc/mounts and /etc/mtab this seems fairly easy to do.
> Yes I agree, and that's exactly what I intend to do (and how I
> was thinking of doing it). I also owe a quota test for the
> doubling of what gets reported from a month ago or so. I
> thought I could address both issues in the same test (unless
> someone feels it's important to have each test have a more
> specific focus).
I think these should be separate tests as they test very different
things. What could be rolled into the first one would be a test
for RT quota reporting - despite the comment in your commit those
should work just fine.
> > If you're motivated for even more cleanups it would be good if all
> > xfs_quota options are actully documented, and making sure the
> > /proc/mounts, /etc/mtab and co handling in xfsprogs doesn't differ
> > for different tools. Currently libxcmd, libxfs and xfs_fsr all
> > have their own variants.
> To be honest I kind of went further with this than I intended
> to and I had to sort of put a stop to it... I have three or
> four other cleanup patches started but I just have to move on
> and so posted what I have working and am content with.
> I think what you suggest are all good but for now I'm not
> planning to work on them.
It's not that important, but maybe we should keep a todo list
for these kinds of tidyups.