[Top] [All Lists]

Re: [PATCH 0/6] xfsprogs: tolerate mount or project errors

To: Alex Elder <aelder@xxxxxxx>
Subject: Re: [PATCH 0/6] xfsprogs: tolerate mount or project errors
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Mon, 3 Oct 2011 09:31:27 -0400
Cc: xfs@xxxxxxxxxxx
In-reply-to: <1317646160-5437-1-git-send-email-aelder@xxxxxxx>
References: <1317646160-5437-1-git-send-email-aelder@xxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Mon, Oct 03, 2011 at 07:49:14AM -0500, Alex Elder wrote:
> The trouble report that led to fixing this had to do with a
> situation in which automount left some sort of artifact in the list
> of mounted filesystems, and any attempt to run xfs_growfs was met
> with an error that prevented it from being run.  The errant entry in
> /proc/self/mounts contained something like this in the mnt_fsname
> field returned by getmntent(): "/tmp/auto7fGuI5 (deleted)"

I'd really like to do some sort of QA for this.  Given that xfs_quota
already has an (uncodumented) -t flag to use a replacement for
/proc/mounts and /etc/mtab this seems fairly easy to do.

If you're motivated for even more cleanups it would be good if all
xfs_quota options are actully documented, and making sure the
/proc/mounts, /etc/mtab and co handling in xfsprogs doesn't differ
for different tools.  Currently libxcmd, libxfs and xfs_fsr all
have their own variants.

<Prev in Thread] Current Thread [Next in Thread>