xfs
[Top] [All Lists]

Re: SEEK_DATA/SEEK_HOLE support

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: SEEK_DATA/SEEK_HOLE support
From: Andi Kleen <andi@xxxxxxxxxxxxxx>
Date: Sun, 02 Oct 2011 12:11:07 -0700
Cc: Jeff Liu <jeff.liu@xxxxxxxxxx>, xfs@xxxxxxxxxxx
In-reply-to: <20111002175902.GA9420@xxxxxxxxxxxxx> (Christoph Hellwig's message of "Sun, 2 Oct 2011 13:59:02 -0400")
References: <4E887D7F.2010306@xxxxxxxxxx> <20111002154259.GA14543@xxxxxxxxxxxxx> <4E888C0D.9060701@xxxxxxxxxx> <20111002175902.GA9420@xxxxxxxxxxxxx>
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux)
Christoph Hellwig <hch@xxxxxxxxxxxxx> writes:
>
> And the most important thing is of course adding QA for it.  Josef
> already wrote an xfstests case that needs to be resurrected, compared
> against the latest Posix draft and if nessecary updated.

Also when you do it please make sure you don't break unlocked lseek()
The patches for that are in Al's queue.  Only take the lock
for SEEK_HOLE/DATA, but not for the other operations. Use the
new helper instead of cut'n'pasting code.

-Andi

-- 
ak@xxxxxxxxxxxxxxx -- Speaking for myself only

<Prev in Thread] Current Thread [Next in Thread>