[Top] [All Lists]

Re: [PATCH v2] xfsdump: handle dump files with checksum bug

To: Bill Kendall <wkendall@xxxxxxx>
Subject: Re: [PATCH v2] xfsdump: handle dump files with checksum bug
From: Alex Elder <aelder@xxxxxxx>
Date: Thu, 29 Sep 2011 09:38:10 -0500
Cc: <xfs@xxxxxxxxxxx>
In-reply-to: <1317156572-11897-1-git-send-email-wkendall@xxxxxxx>
References: <1317156572-11897-1-git-send-email-wkendall@xxxxxxx>
Reply-to: <aelder@xxxxxxx>
On Tue, 2011-09-27 at 15:49 -0500, Bill Kendall wrote:
> xfsdump previously contained a bug in the code which generated
> a checksum on the header for extended attributes. This bug
> was recently fixed, but a new xfsrestore will fail if it
> encounters an old dump file which had checksums enabled. (This
> is unlikely since checksums have just recently been enabled in
> the build, and the above-mentioned bug was fixed at the same time.)
> This patch uses a new flag in an extattrhdr_t to indicate a
> checksum is present. If this is set, the checksum is validated.
> If instead the old checksum flag is set, a warning is issued saying
> the header could not be validated, and xfsrestore will assume the
> header is valid.
> Note that with this change a new dump cannot be restored with an
> old restore which has checksums enabled. But as I mentioned, old
> restores do not have checksums enabled.
> Signed-off-by: Bill Kendall <wkendall@xxxxxxx>

Looks good.

Reviewed-by: Alex Elder <aelder@xxxxxxx>

<Prev in Thread] Current Thread [Next in Thread>