| To: | Alex Elder <aelder@xxxxxxx> |
|---|---|
| Subject: | Re: [PATCH 2/2] xfsprogs: xfs_quota: kill local variable "type" from free_f() |
| From: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
| Date: | Thu, 29 Sep 2011 07:07:50 -0400 |
| Cc: | xfs@xxxxxxxxxxx |
| In-reply-to: | <ccff8f308fbc7e15e9a74f28b5eb98490a0e3c82.1317210237.git.aelder@xxxxxxx> |
| References: | <a14d653e8a238b3207c5076eb6e6f3358e433422.1317210237.git.aelder@xxxxxxx> <ccff8f308fbc7e15e9a74f28b5eb98490a0e3c82.1317210237.git.aelder@xxxxxxx> |
| User-agent: | Mutt/1.5.21 (2010-09-15) |
On Wed, Sep 28, 2011 at 06:44:34AM -0500, Alex Elder wrote: > Only one value is ever really used for the "type" variable in > free_f(), and it indicates that either type of entry in fs_table > is wanted. Just get rid of the variable and make use of the > ability to provide 0 to free_space_list() to indicate that. This sounds like someone planned to add an argument to it to support looking at just normal or project quotas. Given that it never materialized and no one asked for it I'm fine with your cleanup. Reviewed-by: Christoph Hellwig <hch@xxxxxx> |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH 1/2] xfsprogs: libxcmd: allow 0 as a wildcard fs_table entry type selector, Christoph Hellwig |
|---|---|
| Next by Date: | Re: [PATCH 1/5] xfsprogs: libxcmd: don't clobber fs_table on realloc(), Alex Elder |
| Previous by Thread: | [PATCH 2/2] xfsprogs: xfs_quota: kill local variable "type" from free_f(), Alex Elder |
| Next by Thread: | Re: [PATCH 1/2] xfsprogs: libxcmd: allow 0 as a wildcard fs_table entry type selector, Christoph Hellwig |
| Indexes: | [Date] [Thread] [Top] [All Lists] |