xfs
[Top] [All Lists]

Re: [PATCH] xfsprogs: xfs_quota: don't print invalid quota file inode nu

To: Alex Elder <aelder@xxxxxxx>
Subject: Re: [PATCH] xfsprogs: xfs_quota: don't print invalid quota file inode number
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Thu, 29 Sep 2011 07:05:28 -0400
Cc: xfs@xxxxxxxxxxx
In-reply-to: <43b1c14570decac4b102616fb8e9b14d101edc39.1317208532.git.aelder@xxxxxxx>
References: <43b1c14570decac4b102616fb8e9b14d101edc39.1317208532.git.aelder@xxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Wed, Sep 28, 2011 at 06:15:37AM -0500, Alex Elder wrote:
> When the state of quota files is dumped, xfs_quota blindly shows
> whatever inode number is returned by the kernel.  If one of the
> quota types is not enabled or enforced, the inode number provided
> is an invalid value ((__u64) -1).  Rather than print a meaningless
> large integer, print "N/A" in its place to make interpreting the
> result it a little more obvious.
> 
> Signed-off-by: Alex Elder <aelder@xxxxxxx>

Looks good,

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

<Prev in Thread] Current Thread [Next in Thread>