[Top] [All Lists]

Re: [patch 1/2/4] mm: writeback: cleanups in preparation for per-zone di

To: Johannes Weiner <jweiner@xxxxxxxxxx>
Subject: Re: [patch 1/2/4] mm: writeback: cleanups in preparation for per-zone dirty limits
From: Mel Gorman <mgorman@xxxxxxx>
Date: Wed, 28 Sep 2011 10:27:19 +0100
Cc: Andrew Morton <akpm@xxxxxxxxxx>, Christoph Hellwig <hch@xxxxxxxxxxxxx>, Dave Chinner <david@xxxxxxxxxxxxx>, Wu Fengguang <fengguang.wu@xxxxxxxxx>, Jan Kara <jack@xxxxxxx>, Rik van Riel <riel@xxxxxxxxxx>, Minchan Kim <minchan.kim@xxxxxxxxx>, Chris Mason <chris.mason@xxxxxxxxxx>, "Theodore Ts'o" <tytso@xxxxxxx>, Andreas Dilger <adilger.kernel@xxxxxxxxx>, xfs@xxxxxxxxxxx, linux-btrfs@xxxxxxxxxxxxxxx, linux-ext4@xxxxxxxxxxxxxxx, linux-mm@xxxxxxxxx, linux-fsdevel@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
In-reply-to: <20110923144107.GB2606@xxxxxxxxxx>
References: <1316526315-16801-1-git-send-email-jweiner@xxxxxxxxxx> <1316526315-16801-3-git-send-email-jweiner@xxxxxxxxxx> <20110921160226.1bf74494.akpm@xxxxxxxxxx> <20110922085242.GA29046@xxxxxxxxxx> <20110923144107.GB2606@xxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Fri, Sep 23, 2011 at 04:41:07PM +0200, Johannes Weiner wrote:
> On Thu, Sep 22, 2011 at 10:52:42AM +0200, Johannes Weiner wrote:
> > On Wed, Sep 21, 2011 at 04:02:26PM -0700, Andrew Morton wrote:
> > > Should we rename determine_dirtyable_memory() to
> > > global_dirtyable_memory(), to get some sense of its relationship with
> > > zone_dirtyable_memory()?
> > 
> > Sounds good.
> ---
> The next patch will introduce per-zone dirty limiting functions in
> addition to the traditional global dirty limiting.
> Rename determine_dirtyable_memory() to global_dirtyable_memory()
> before adding the zone-specific version, and fix up its documentation.
> Also, move the functions to determine the dirtyable memory and the
> function to calculate the dirty limit based on that together so that
> their relationship is more apparent and that they can be commented on
> as a group.
> Signed-off-by: Johannes Weiner <jweiner@xxxxxxxxxx>

Acked-by: Mel Gorman <mel@xxxxxxx>

Mel Gorman

<Prev in Thread] Current Thread [Next in Thread>