xfs
[Top] [All Lists]

Re: [patch 1/2/4] mm: writeback: cleanups in preparation for per-zone di

To: Johannes Weiner <jweiner@xxxxxxxxxx>
Subject: Re: [patch 1/2/4] mm: writeback: cleanups in preparation for per-zone dirty limits
From: Minchan Kim <minchan.kim@xxxxxxxxx>
Date: Wed, 28 Sep 2011 14:57:14 +0900
Cc: Andrew Morton <akpm@xxxxxxxxxx>, Mel Gorman <mgorman@xxxxxxx>, Christoph Hellwig <hch@xxxxxxxxxxxxx>, Dave Chinner <david@xxxxxxxxxxxxx>, Wu Fengguang <fengguang.wu@xxxxxxxxx>, Jan Kara <jack@xxxxxxx>, Rik van Riel <riel@xxxxxxxxxx>, Chris Mason <chris.mason@xxxxxxxxxx>, "Theodore Ts'o" <tytso@xxxxxxx>, Andreas Dilger <adilger.kernel@xxxxxxxxx>, xfs@xxxxxxxxxxx, linux-btrfs@xxxxxxxxxxxxxxx, linux-ext4@xxxxxxxxxxxxxxx, linux-mm@xxxxxxxxx, linux-fsdevel@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=LBEVo00yW5Kf7mk0C8gvVzcaULSrpeOpIURrkhHrjt0=; b=hGFM6V1VNFTmxtIxfkQ53j+AIyLiNRyh0z1oc4zu+E/u2mUTPRIHgyjaHB8JU1mE5y S0Argm9N83R0l5Y2/pISz0vNJ+bG0JqIcNznrVFeUgPicd3BX/CwvjNLfdeQY1jIHrMC KELbwUtIKoYDepa2tBpOZpZQ6ACjBakGBd5Ds=
In-reply-to: <20110923144107.GB2606@xxxxxxxxxx>
References: <1316526315-16801-1-git-send-email-jweiner@xxxxxxxxxx> <1316526315-16801-3-git-send-email-jweiner@xxxxxxxxxx> <20110921160226.1bf74494.akpm@xxxxxxxxxx> <20110922085242.GA29046@xxxxxxxxxx> <20110923144107.GB2606@xxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Fri, Sep 23, 2011 at 04:41:07PM +0200, Johannes Weiner wrote:
> On Thu, Sep 22, 2011 at 10:52:42AM +0200, Johannes Weiner wrote:
> > On Wed, Sep 21, 2011 at 04:02:26PM -0700, Andrew Morton wrote:
> > > Should we rename determine_dirtyable_memory() to
> > > global_dirtyable_memory(), to get some sense of its relationship with
> > > zone_dirtyable_memory()?
> > 
> > Sounds good.
> 
> ---
> 
> The next patch will introduce per-zone dirty limiting functions in
> addition to the traditional global dirty limiting.
> 
> Rename determine_dirtyable_memory() to global_dirtyable_memory()
> before adding the zone-specific version, and fix up its documentation.
> 
> Also, move the functions to determine the dirtyable memory and the
> function to calculate the dirty limit based on that together so that
> their relationship is more apparent and that they can be commented on
> as a group.
> 
> Signed-off-by: Johannes Weiner <jweiner@xxxxxxxxxx>
Reviewed-by: Minchan Kim <minchan.kim@xxxxxxxxx>
-- 
Kinds regards,
Minchan Kim

<Prev in Thread] Current Thread [Next in Thread>