xfs
[Top] [All Lists]

Re: [PATCH] xfsdump: handle dump files with checksum bug

To: aelder@xxxxxxx
Subject: Re: [PATCH] xfsdump: handle dump files with checksum bug
From: Bill Kendall <wkendall@xxxxxxx>
Date: Tue, 27 Sep 2011 14:17:04 -0500
Cc: xfs@xxxxxxxxxxx
In-reply-to: <1316791615.2879.50.camel@doink>
References: <1316781902-19803-1-git-send-email-wkendall@xxxxxxx> <1316791615.2879.50.camel@doink>
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.18) Gecko/20110617 Thunderbird/3.1.11
On 09/23/2011 10:26 AM, Alex Elder wrote:
On Fri, 2011-09-23 at 07:45 -0500, Bill Kendall wrote:
+                               mlog( MLOG_NORMAL | MLOG_WARNING, _(
+                                       "extattr header checksum "
+                                       "could not be verified\n") );

Is there any way to slightly change this message so
that someone who saw it would feel like "I got this
warning but it's really OK"?  If I were a user and
got this message I would be a little afraid that
it meant something was really wrong with what got
restored--possibly the whole thing, or just on
some unnamed file, never to be found.

Maybe "old-style extattr header checksums being
ignored".  (I'm sure you can come up with better,
I just like to offer *something* when I suggest
a change.)

I more or less like what you've suggested. How about this:

   "ignoring old-style extattr header checksums"

Bill

<Prev in Thread] Current Thread [Next in Thread>