xfs
[Top] [All Lists]

Re: [PATCH v4] commit.rc: Add helper for math operation using bc

To: Lukas Czerner <lczerner@xxxxxxxxxx>
Subject: Re: [PATCH v4] commit.rc: Add helper for math operation using bc
From: Alex Elder <aelder@xxxxxxx>
Date: Mon, 26 Sep 2011 16:32:17 -0500
Cc: <xfs@xxxxxxxxxxx>
In-reply-to: <1317062709-2133-1-git-send-email-lczerner@xxxxxxxxxx>
References: <1316787311-23428-1-git-send-email-lczerner@xxxxxxxxxx> <1317062709-2133-1-git-send-email-lczerner@xxxxxxxxxx>
Reply-to: <aelder@xxxxxxx>
On Mon, 2011-09-26 at 20:45 +0200, Lukas Czerner wrote:
> Sometimes using bash $(()) math might not be enough due to some
> limitation (big numbers), so add helper using 'bc' program. For
> now the results are only in perfect numbers (as in bash) since this is
> all I need for now.
> 
> This commit also adds _require_math() helper which should be called by
> every test which uses _math() since it requires "bc" to be installed on
> the system.
> 
> Signed-off-by: Lukas Czerner <lczerner@xxxxxxxxxx>

Looks fine.  Thanks for updating it.

Reviewed-by: Alex Elder <aelder@xxxxxxx>


<Prev in Thread] Current Thread [Next in Thread>