xfs
[Top] [All Lists]

Re: xfstests 258: Test xfs fs creation with fs size close to 4 TB

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: xfstests 258: Test xfs fs creation with fs size close to 4 TB
From: Alex Elder <aelder@xxxxxxx>
Date: Mon, 26 Sep 2011 07:18:46 -0500
Cc: Boris Ranto <branto@xxxxxxxxxx>, Eric Sandeen <sandeen@xxxxxxxxxx>, xfs-oss <xfs@xxxxxxxxxxx>
In-reply-to: <20110926114458.GA1176@xxxxxxxxxxxxx>
References: <1316613160.781.8.camel@xxxxxxxxxxxxxxxxxxxxxxxxxx> <20110926114458.GA1176@xxxxxxxxxxxxx>
Reply-to: <aelder@xxxxxxx>
On Mon, 2011-09-26 at 07:44 -0400, Christoph Hellwig wrote:
> This one actually fails for me in a 32-bit userspace VM:

This is my fault, and you busted me doing something I
should not have.

It doesn't matter in this case, but there is a window in
which "testfile" is undefined but gets referenced in
_cleanup() (which could get called due to interrupt).
I "trivially" moved the definition to fix that oversight
and as a result broke the test.

I won't do that any more without taking proper credit
when I commit.

Sorry Boris (and all).

Your fix looks fine, Christoph.

Reviewed-by: Alex Elder <aelder@xxxxxxx>


<Prev in Thread] Current Thread [Next in Thread>