xfs
[Top] [All Lists]

Re: [PATCH 2/2] Add test 257: Check proper FITRIM argument handling

To: Michael Monnerie <michael.monnerie@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [PATCH 2/2] Add test 257: Check proper FITRIM argument handling
From: Lukas Czerner <lczerner@xxxxxxxxxx>
Date: Mon, 26 Sep 2011 08:15:56 +0200 (CEST)
Cc: xfs@xxxxxxxxxxx, Lukas Czerner <lczerner@xxxxxxxxxx>, aelder@xxxxxxx
In-reply-to: <201109240104.08410@xxxxxx>
References: <1316787311-23428-1-git-send-email-lczerner@xxxxxxxxxx> <1316787311-23428-2-git-send-email-lczerner@xxxxxxxxxx> <201109240104.08410@xxxxxx>
User-agent: Alpine 2.00 (LFD 1167 2008-08-23)
On Sat, 24 Sep 2011, Michael Monnerie wrote:

> On Freitag, 23. September 2011 Lukas Czerner wrote:
> > +# FS QA Test No. 251
> > +#
> > +# This test was created in order to verify filesystem FITRIM
> > implementation. +# By many concurrent copy and remove operations and
> > checking that files +# does not change after copied into SCRATCH_MNT
> > test if FITRIM implementation +# corrupts the filesystem
> > (data/metadata).
> 
> This is a bit misspelled and (for me being non-native english) hard to 
> understand. I guess it should be
> 
> This test was created in order to verify the filesystem FITRIM 
> implementation by doing many concurrent copy and remove operations and
> checking that files do not change after being copied into SCRATCH_MNT.
> Test if FITRIM implementation corrupts the filesystem (data/metadata).
> 
> (Where I'm not sure if the last sentence belongs there, or in a separate 
> paragraph, or is redundant to the first sentence)
> 

Oops, the whole paragraph does not belong there. It is leftover from a
different test I have wrote earlier. Thanks for noticing it and sorry
for the confusion.

-Lukas

<Prev in Thread] Current Thread [Next in Thread>