[Top] [All Lists]

Re: [PATCH] xfstests: Assume yes when test device is not partitioned

To: Prasad Joshi <prasadjoshi.linux@xxxxxxxxx>
Subject: Re: [PATCH] xfstests: Assume yes when test device is not partitioned
From: Alex Elder <aelder@xxxxxxx>
Date: Thu, 22 Sep 2011 17:02:49 -0500
Cc: <linux-ext4@xxxxxxxxxxxxxxx>, Chaitanya Kulkarni <chaitanyakulkarni15@xxxxxxxxx>, <xfs@xxxxxxxxxxx>
In-reply-to: <1316726084.2009.85.camel@doink>
References: <1315038799-2150-1-git-send-email-prasadjoshi.linux@xxxxxxxxx> <1316726084.2009.85.camel@doink>
Reply-to: <aelder@xxxxxxx>
On Thu, 2011-09-22 at 16:14 -0500, Alex Elder wrote:
> On Sat, 2011-09-03 at 14:03 +0530, Prasad Joshi wrote:
> > If an entire device used for file system creation, the mkfs.ext2/3/4
> > asks for confirmation before proceeding. Since the device is
> > configured for testing it is safe to assume positive response
> > during mkfs.
> > 
> > The patch also replaces hard coded mkfs path with MKFS_PROG variable.
> > 
> > Signed-off-by: Chaitanya Kulkarni <chaitanyakulkarni15@xxxxxxxxx>
> > Signed-off-by: Prasad Joshi <prasadjoshi.linux@xxxxxxxxx>
> Thanks for submitting a patch, Prasad (and Chaitanya).
> Can you please re-submit this?  Based on feedback what
> we're looking for would be:
> [PATCH 0/2] description e-mail
> [PATCH 1/2] patch that substitutes /sbin/mkfs with ${MKFS_PROG}
> [PATCH 2/2] patch that adds a '-f' flag to ${MKFS_PROG}.${FSTYP}
>             for all ext* filesystem types.

Oh, and while I'm thinking about it...

/sbin/mkfs.${FSTYP} and ${MKFS_PROG}.${FSTYP} are most likely
incorrect.  The switch to MKFS_PROG at least finds where the
mkfs executable lies, but in theory anyway there is no guarantee
that, for example, the mkfs.xfs program lies in the same directory.
The mkfs executable uses the PATH (via execvp()) to find the
filesystem-specific mkfs program to use, and I expect we should
work the same way.


<Prev in Thread] Current Thread [Next in Thread>