xfs
[Top] [All Lists]

Re: [PATCH 2/2 v2][xfstests] fstrim: Use strtoull instead of strtoul

To: Lukas Czerner <lczerner@xxxxxxxxxx>
Subject: Re: [PATCH 2/2 v2][xfstests] fstrim: Use strtoull instead of strtoul
From: Alex Elder <aelder@xxxxxxx>
Date: Thu, 22 Sep 2011 15:59:14 -0500
Cc: <xfs@xxxxxxxxxxx>
In-reply-to: <1315410523-23925-2-git-send-email-lczerner@xxxxxxxxxx>
References: <1315410523-23925-1-git-send-email-lczerner@xxxxxxxxxx> <1315410523-23925-2-git-send-email-lczerner@xxxxxxxxxx>
Reply-to: <aelder@xxxxxxx>
On Wed, 2011-09-07 at 17:48 +0200, Lukas Czerner wrote:
> When we are parsing input arguments we should really use stroull to get
> unsigned long long numbers, since this is what we can specify on the
> command line. With this fix it should parse long numbers on the 32 bit
> architecture correctly.
> 
> Signed-off-by: Lukas Czerner <lczerner@xxxxxxxxxx>

This looks good, and it can be applied independent of the
first patch in this series.  (And at this point I plan to
commit this first rather than wait.)

Reviewed-by: Alex Elder <aelder@xxxxxxx>


<Prev in Thread] Current Thread [Next in Thread>